[Bug 729896] glupload: Ignores stride when uploading raw data

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=729896
  GStreamer | gst-plugins-bad | git

--- Comment #22 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-05-12 22:28:03 UTC ---
Still not fixed, but found this important issue:

commit e0cfd6e26b53b9530b0a3494b883c490714b8da7
Author: Nicolas Dufresne <nicolas.dufresne at collabora.com>
Date:   Mon May 12 13:18:50 2014 -0400

    video-info: Also check the stride and offset are equal

    gst_video_info_is_equal() was not checking if stride and offset
    had changed.

    https://bugzilla.gnome.org/show_bug.cgi?id=729896


Which cause the old config to remain. After this change we would failed, cause
texture was gone.

commit 2d0a791348c0a37cc90c99741cd64527d90d7826
Author: Nicolas Dufresne <nicolas.dufresne at collabora.com>
Date:   Mon May 12 13:50:47 2014 -0400

    glupload: Ensure we still have a texture after upload_set_format()

    gst_gl_upload_set_format() resets the upload, hence the texture.
    So we need to ensure we have a texture after this call when
    uploading.

And I added patches to address the issue I mentioned.

commit 864e1511c7cf38c1c24e1c41816bb75f71f52916
Author: Nicolas Dufresne <nicolas.dufresne at collabora.com>
Date:   Mon May 12 12:59:59 2014 -0400

    glupload: Correctly update the video info from video meta

    Using gst_video_info_set_format() isn't complete when updating
    a video info from video meta.

commit 4f84a6124a719c2a9c927b5e91b36f5d5b20d617
Author: Nicolas Dufresne <nicolas.dufresne at collabora.com>
Date:   Mon May 12 12:57:18 2014 -0400

    glupload: Correctly update video info in upload fallback

    When the upload accelerated method fails, we fallback to an upload,
    but the video info was not correctly updated.

But sadly, I still get stride issues.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.