[Bug 730010] gst-play: audio_sink and video_sink strings are not freed

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=730010
  GStreamer | gst-plugins-base | 1.x

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #276437|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-05-13 07:16:43 UTC ---
Review of attachment 276437:
 --> (https://bugzilla.gnome.org/review?bug=730010&attachment=276437)

::: tools/gst-play.c
@@ +790,3 @@

+  g_free (audio_sink);
+  g_free (video_sink);

While this is correct, it would probably be more consistent to free them inside
play_free(). Also in the "early return" cases in main() these strings would
still be leaked, together with e.g. the playlist_file string

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.