[Bug 730133] motioncells:fix memleak

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=730133
  GStreamer | gst-plugins-bad | 1.x

Thiago Sousa Santos <thiagossantos> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #276548|none                        |needs-work
             status|                            |

--- Comment #3 from Thiago Sousa Santos <thiagossantos at gmail.com> 2014-05-14 18:30:54 UTC ---
Review of attachment 276548:
 --> (https://bugzilla.gnome.org/review?bug=730133&attachment=276548)

Just a minor improvement below.

::: ext/opencv/gstmotioncells.c
@@ +864,3 @@
   GST_OBJECT_LOCK (filter);
+  if (!gst_buffer_is_writable (buf))
+    buf = gst_buffer_make_writable (buf);

You are making the buffer writable even when the 'calculate_motion' is set to
false. It would be better to only do it if the buffer is actually going to be
used.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.