[Bug 730141] motioncells improvements

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=730141
  GStreamer | gst-plugins-bad | 1.x

Thiago Sousa Santos <thiagossantos> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #276552|none                        |reviewed
             status|                            |

--- Comment #2 from Thiago Sousa Santos <thiagossantos at gmail.com> 2014-05-15 00:13:45 UTC ---
Review of attachment 276552:
 --> (https://bugzilla.gnome.org/review?bug=730141&attachment=276552)

I'd recommend to split this into 2 separate patches as it  addresses 2 issues.
Also this and the other patch on the bug doesn't apply cleanly on master
anymore. Could you rebase, please?

Thanks

::: ext/opencv/MotionCells.cpp
@@ -150,1 +151,1 @@


Let me try to understand this. It actually skips frames untip the
'sum_framecnt' value is reached?

Is this something imported from some opencv example or just arbitrary?
This patch seems to follow the progression so it should be fine but it would be
better to have some way to set this as a property.

@@ -200,3 @@
       performMotionMask (motionmaskcellsidx, motionmaskcells_count);
     if (getIsNonZero (m_pbwImage)) {    //detect Motion
-      GST_DEBUG ("DETECT MOTION \n");

Please do the log changes on a separate patch.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.