[Bug 730200] v4l2videodec: v4l2bufferpool must be updated according to driver requirement

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=730200
  GStreamer | gst-plugins-good | 1.x

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #276609|none                        |needs-work
             status|                            |

--- Comment #2 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-05-15 16:02:42 UTC ---
Review of attachment 276609:
 --> (https://bugzilla.gnome.org/review?bug=730200&attachment=276609)

Small changes, but good otherwise.

::: sys/v4l2/gstv4l2bufferpool.c
@@ +670,3 @@

+        /* The initial minimum is could be provide either by GstBufferPool or
+         * driver needs. */

Some english typo here.

@@ +671,3 @@
+        /* The initial minimum is could be provide either by GstBufferPool or
+         * driver needs. */
+        min_buffers = MAX (min_buffers, count);

So now, if the driver gives less then expected, it will most likely fail in
_start(). Previously it would at least start. This code was not initially
expecting the count to be bigger then expected ;-P

I think we can just do that now:

min_buffers = count;

And that would be best effort. Even though there is a risk for buffer stall (in
both cases). That's what the CID V4L2_CID_MIN_BUFFERS_FOR_CAPTURE and
V4L2_CID_MIN_BUFFERS_FOR_OUTPUT are for.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.