[Bug 730217] rtpsession: do not mark internal senders as expired

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri May 16 08:05:59 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=730217
  GStreamer | gst-plugins-good | git

--- Comment #5 from Aleix Conchillo Flaqué <aleix at oblong.com> 2014-05-16 15:05:50 UTC ---

That's what I did initially but then I thought that this check

          if (source->ssrc != sess->suggested_ssrc) {

didn't make sense when the session has multiple internal senders with different
ssrc. And also that last_activity was not updated for some reason that I still
didn't knew.

But yes, updating last_activity would solve this problem too as we wouldn't
reach the check above.

If we the check above doesn't really make sense for the use case I mentioned
then I would skip doing it with my patch. And if updating last_activity also
makes sense when sending RTP packets, then I would also include that.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list