[Bug 728502] ximagesrc has a serious shmem leak

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=728502
  GStreamer | gst-plugins-good | 1.2.4

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #274713|none                        |needs-work
             status|                            |

--- Comment #7 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-05-20 21:12:19 UTC ---
Review of attachment 274713:
 --> (https://bugzilla.gnome.org/review?bug=728502&attachment=274713)

::: sys/ximage/gstximagesrc.c
@@ +458,3 @@
   while (ximagesrc->buffer_pool != NULL) {
+    if (ximage != NULL)
+      gst_ximage_buffer_free (ximage);

And 4 lines lower you'll get a double free if ((meta->width !=
ximagesrc->width) || (meta->height != ximagesrc->height)). To be honest I don't
get what the code is trying to do, but I agree it's not right. Though this is
the wrong fix.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.