[Bug 729764] pnmdec: Not respecting downstream rowstride
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Tue May 20 22:19:16 PDT 2014
https://bugzilla.gnome.org/show_bug.cgi?id=729764
GStreamer | gst-plugins-bad | git
--- Comment #4 from Sanjay NM <sanjay.nm at samsung.com> 2014-05-21 05:19:12 UTC ---
Thanks for your review. At present pnmdec always aligns rowstride to 4 and then
returns this buffer. If width is say 1919, considering bits per pixel of 3
rowstride becomes 1919 * 3 = 5757. This at present is getting adjusted to 5760
(multiple of 4) and then buffer gets returned. Sorry for confusing by saying
width becomes 1920 (5760/4 = 1920). I have updated the patch to take an input
parameter rowstrideorig. If this is set to TRUE then pnmdec will not align
rowstride to 4 but will return the original (width * bpp) number of bytes.
If no parameter is passed then the behavior is same as before. That is it will
make the rowstride alignment to 4 and return. This is more of an enhancement.
I have tested the decoder by using following commands and it is working well.
gst-launch-1.0 filesrc location=odd.pnm ! pnmdec rowstrideorig=TRUE ! filesink
location=out.raw
gst-launch-1.0 filesrc location=odd.pnm ! pnmdec ! filesink location=out.raw
I will create separate patches for your suggestions to use GstAdapter.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list