[Bug 730496] ID3 tag "TPE3" not mapped to gstreamer tag

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=730496
  GStreamer | gst-plugins-base | git

Thiago Sousa Santos <thiagossantos> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #276917|none                        |reviewed
             status|                            |

--- Comment #1 from Thiago Sousa Santos <thiagossantos at gmail.com> 2014-05-21 13:18:05 UTC ---
Review of attachment 276917:
 --> (https://bugzilla.gnome.org/review?bug=730496&attachment=276917)

Do you have one or more samples containing TPE* id3 tags? What would be the
values in them? Might help understanding what id3 mean with those tags as they
seem a bit ambiguous/overlapping.

::: gst-libs/gst/tag/gstid3tag.c
@@ +114,3 @@
   {GST_TAG_INTERPRETED_BY, "TPE4"},
   {GST_TAG_MUSICAL_KEY, "TKEY"},
+  {GST_TAG_PERFORMER, "TPE3"},

I'd like a second opinion here, currently we have

TPE1 -> GST_TAG_ARTIST
TPE2 -> GST_TAG_ALBUM_ARTIST (not exactly accurate)
TPE3 -> ???
TPE4 -> GST_TAG_INTERPRETED_BY

Performer and artist seem to be kind of overlapping, and TPE3 can also mean
conductor... Maybe investigating some samples will make this more clear.

The id3 docs (http://id3.org/id3v2.4.0-frames) says:

  4.2.2 TPE1 Lead performer(s)/Soloist(s)
  4.2.2 TPE2 Band/orchestra/accompaniment
  4.2.2 TPE3 Conductor/performer refinement
  4.2.2 TPE4 Interpreted, remixed, or otherwise modified by

4.2.2.   Involved persons frames

  TPE1
   The 'Lead artist/Lead performer/Soloist/Performing group' is
   used for the main artist.

  TPE2
   The 'Band/Orchestra/Accompaniment' frame is used for additional
   information about the performers in the recording.

  TPE3
   The 'Conductor' frame is used for the name of the conductor.

  TPE4
   The 'Interpreted, remixed, or otherwise modified by' frame contains
   more information about the people behind a remix and similar
   interpretations of another existing piece.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.