[Bug 705129] androidmedia: add support for video encoding

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=705129
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #256807|none                        |reviewed
             status|                            |

--- Comment #16 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-05-23 07:32:39 UTC ---
Review of attachment 256807:
 --> (https://bugzilla.gnome.org/review?bug=705129&attachment=256807)

::: sys/androidmedia/gstamcvideoenc.c
@@ +820,3 @@
+  g_object_class_install_property (gobject_class, PROP_BIT_RATE,
+      g_param_spec_uint ("bitrate", "Bitrate", "Bitrate in kbit/sec", 1,
+          100 * 1024, BIT_RATE_DEFAULT,

Why limit it at that number? Just use G_MAXINT :) And we do bitrate in bit/s
usually

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.