[Bug 709224] audio/videodecoder: Not returning GST_FLOW_EOS when after segment

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=709224
  GStreamer | gst-plugins-base | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #277171|none                        |needs-work
             status|                            |

--- Comment #70 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-05-26 07:08:23 UTC ---
Review of attachment 277171:
 --> (https://bugzilla.gnome.org/review?bug=709224&attachment=277171)

Looks good to me, just misses some cleanup

::: gst/gstutils.c
@@ +3868,3 @@
+  GstFlowReturn last_ret;
+
+  GstFlowCombinerGetStreamFlow getstreamflow_func;

This is unused, right? Please remove :)

::: gst/gstutils.h
@@ +33,3 @@
 G_BEGIN_DECLS

+typedef GstFlowReturn (*GstFlowCombinerGetStreamFlow)(gpointer stream);

And here remove too

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.