[Bug 709224] audio/videodecoder: Not returning GST_FLOW_EOS when after segment

Mon May 26 21:03:14 PDT 2014

https://bugzilla.gnome.org/show_bug.cgi?id=709224
  GStreamer | gstreamer (core) | git

Thiago Sousa Santos <thiagossantos> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
          Component|gst-plugins-base            |gstreamer (core)
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |1.3.3
         OS/Version|Linux                       |All

--- Comment #76 from Thiago Sousa Santos <thiagossantos at gmail.com> 2014-05-27 02:33:08 UTC ---
Thanks everyone for the reviews and help.
Here is the long patch list.

core:
commit 9e8bd15c124eb62fdaeb7dcbae40cf816f8a63a9
Author: Thiago Santos <ts.santos at sisa.samsung.com>
Date:   Mon May 26 12:31:33 2014 -0300

    flowcombiner: add GstFlowCombiner

    Adds a utility struct that is capable of storing and aggregating flow
return
    associated with pads.

    This way all demuxers will have a standard function to use and have the
    same expected results.

    Includes tests.

    https://bugzilla.gnome.org/show_bug.cgi?id=709224

commit c6f92562b666d09a01545bee4fce7536d44fc5cc
Author: Thiago Santos <ts.santos at sisa.samsung.com>
Date:   Fri May 23 13:25:35 2014 -0300

    pad: store last flow return and provide acessor function

    Stores the last result of a gst_pad_push or a pull on the GstPad and
provide
    a getter and a macro to access this field.

    Whenever the pad is inactive it is set to FLUSHING

    API: gst_pad_get_last_flow_return

    https://bugzilla.gnome.org/show_bug.cgi?id=709224

base:
commit 5d35675a74d57bc45e7bc531441487d0e809bca9
Author: Thiago Santos <ts.santos at sisa.samsung.com>
Date:   Mon May 26 20:57:30 2014 -0300

    tests: videodecoder: audiodecoder: add tests for eos after segment

    Tests that pushing a buffer after the segment returns EOS

commit 0cb5ea439669b1791b66b7bbd5f80e90a9c6b134
Author: Thiago Santos <ts.santos at sisa.samsung.com>
Date:   Mon May 26 21:24:07 2014 -0300

    videodecoder: actually return the push result in backwards playback

    It was always returning _OK regardless of what downstream returned

commit ff9e37ea668e06b13ab4b739f0eb87a3607310e3
Author: Thiago Santos <ts.santos at sisa.samsung.com>
Date:   Mon May 26 12:44:48 2014 -0300

    videodecoder: return EOS when segment is over

    if a buffer is clipped by being completely out of segment, check if this
    buffer is after the end of the segment and return EOS upstream

    https://bugzilla.gnome.org/show_bug.cgi?id=709224

commit 09b8f902eab42d10b5392bc6b2f9f78cd7e670f5
Author: Thiago Santos <ts.santos at sisa.samsung.com>
Date:   Mon May 26 12:44:38 2014 -0300

    audiodecoder: return EOS when segment is over

    if a buffer is clipped by being completely out of segment, check if this
    buffer is after the end of the segment and return EOS upstream

    https://bugzilla.gnome.org/show_bug.cgi?id=709224

commit d3ca7271dcd2369434df1652684993af690d9f95
Author: Thiago Santos <ts.santos at sisa.samsung.com>
Date:   Mon May 26 11:45:29 2014 -0300

    oggdemux: use new gstutils helper GstFlowCombiner

    Fixes the handling of GST_FLOW_EOS by using the helper object
    from gstutils that does the correct combination of flow returns.

good:
commit fd6b3488984ecd8b9b1e01e2a92028be0cc6df7c
Author: Thiago Santos <ts.santos at sisa.samsung.com>
Date:   Mon May 26 19:47:39 2014 -0300

    avidemux: remove stream last flow return

    GstPad already stores that information

    https://bugzilla.gnome.org/show_bug.cgi?id=709224

commit 2b454bf87f7bfcdbcd8069bfca76c81004233025
Author: Thiago Santos <ts.santos at sisa.samsung.com>
Date:   Mon May 26 19:37:46 2014 -0300

    qtdemux: remove last flow return from stream struct

    It is already stored on GstPad on core

    https://bugzilla.gnome.org/show_bug.cgi?id=709224

commit 3b887887be14ca7df0a9ffa9efc8f8ac94dc39f9
Author: Thiago Santos <ts.santos at sisa.samsung.com>
Date:   Mon May 26 19:19:45 2014 -0300

    flvdemux: Use GstFlowCombiner

    Use the flow combiner to have the standard combination results and avoid
    repeating the same code

    https://bugzilla.gnome.org/show_bug.cgi?id=709224

commit c7c25071e313497b69eee472812d66df82f0087c
Author: Thiago Santos <ts.santos at sisa.samsung.com>
Date:   Mon May 26 13:21:25 2014 -0300

    matroskademux: use GstFlowCombiner

    Use the flow combiner to have the standard combination results and avoid
    repeating the same code

    https://bugzilla.gnome.org/show_bug.cgi?id=709224

commit da3c0316278933dde369cf2e9f15d8e3a61a32ea
Author: Thiago Santos <ts.santos at sisa.samsung.com>
Date:   Mon May 26 13:04:10 2014 -0300

    avidemux: use GstFlowCombiner

    Removes flow return combination code to use the newly added GstFlowCombiner

commit 4b0ce7dc305b041b3c11ddce20bbc0872e049a8e
Author: Thiago Santos <ts.santos at sisa.samsung.com>
Date:   Fri May 23 17:53:00 2014 -0300

    qtdemux: use GstFlowCombiner

    Removes the common code to combining flow returns to let it be
    handled by core gstutils' GstFlowCombiner

    https://bugzilla.gnome.org/show_bug.cgi?id=709224

ugly:
commit 8263652d2c88f7fb7ca4dde913e6fe1644a547cc
Author: Thiago Santos <ts.santos at sisa.samsung.com>
Date:   Mon May 26 17:55:43 2014 -0300

    rmdemux: use GstFlowCombiner

    Removes flow return combination code to use the newly added GstFlowCombiner

    https://bugzilla.gnome.org/show_bug.cgi?id=709224

commit df768bc99cbf6fc4b2db880e1c51ac5425780a6d
Author: Thiago Santos <ts.santos at sisa.samsung.com>
Date:   Fri May 23 18:17:11 2014 -0300

    asfdemux: use GstFlowCombiner

    Removes flow return combination code to use the newly added GstFlowCombiner

    https://bugzilla.gnome.org/show_bug.cgi?id=709224

bad:
commit ae839d8dc293800dcfbfad7ee767944bf5488b1e
Author: Thiago Santos <ts.santos at sisa.samsung.com>
Date:   Mon May 26 17:34:40 2014 -0300

    mxfdemux: use GstFlowCombiner

    Removes flow return combination code to use the newly added GstFlowCombiner

    https://bugzilla.gnome.org/show_bug.cgi?id=709224

commit 6dc571b5cfa897e30f36993ddc74f43f1d1e2178
Author: Thiago Santos <ts.santos at sisa.samsung.com>
Date:   Mon May 26 17:18:01 2014 -0300

    mpegdemux: use GstFlowCombiner

    Removes flow return combination code to use the newly added GstFlowCombiner

    https://bugzilla.gnome.org/show_bug.cgi?id=709224

commit b66012a586cd94194a0d16dc56c15b9e7398c244
Author: Thiago Santos <ts.santos at sisa.samsung.com>
Date:   Fri May 23 18:26:57 2014 -0300

    tsdemux: use GstFlowCombiner

    Removes flow return combination code to use the newly added GstFlowCombiner

gst-libav:
commit 66588ae60df40c60052a9f094444b15b5faf9c07
Author: Thiago Santos <ts.santos at sisa.samsung.com>
Date:   Mon May 26 16:04:50 2014 -0300

    avdemux: use GstFlowCombiner

    To remove replicated code from all demuxers to a single standard way
    of aggregating flow returns

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.