[Bug 730783] bytereader: Improve the performance to find start code for H.264 and H.265

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=730783
  GStreamer | gstreamer (core) | git

Edward Hervey <bilboed> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |bilboed at bilboed.com
            Summary|basesrc: Improve the        |bytereader: Improve the
                   |performance to find start   |performance to find start
                   |code for H.264 and H.265    |code for H.264 and H.265
     Ever Confirmed|0                           |1

--- Comment #1 from Edward Hervey <bilboed at bilboed.com> 2014-05-27 05:41:51 UTC ---
The idea makes sense.

I'm not a neon expert, but isn't vceq.i8 checking for 0x00 (and not 0x0000) ?

Furthermore, aren't there restrictions on alignments for the input 'pdata'
variable ? Looks as though it would need to be 16-bit-aligned.

In terms of code clarity, it would also be better if you could either:
* avoid duplicating the code-paths and variables (i.e. just #if the new
variables and asm path instead of duplicating everything).
* or #if the whole function (i.e. add a new one instead of modifying the
existing one).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.