[Bug 726423] playbin/decodebin: aggregate buffering messages

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=726423
  GStreamer | gstreamer (core) | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #277293|none                        |needs-work
             status|                            |

--- Comment #7 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-05-27 14:58:44 UTC ---
Review of attachment 277293:
 --> (https://bugzilla.gnome.org/review?bug=726423&attachment=277293)

Looks good, just minor comment

::: gst/playback/gstdecodebin2.c
@@ +4667,3 @@
+        smaller = msg;
+      }
+      dbin->buffering_status = g_list_prepend (dbin->buffering_status, msg);

The refcounting here is a bit convoluted... can you clean that up? Always store
a new ref in the list and ...

@@ +4676,3 @@
+      /* we are posting the original received msg */
+    } else {
+      gst_message_replace (&msg, smaller);

Here make sure to unref the original message or forward-post it

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.