[Bug 641204] dvbsrc: Faster tuning logic: Use poll instead of artificial usleep

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=641204
  GStreamer | gst-plugins-bad | git

Edward Hervey <bilboed> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #277252|none                        |needs-work
             status|                            |

--- Comment #26 from Edward Hervey <bilboed at bilboed.com> 2014-05-28 09:34:51 UTC ---
Review of attachment 277252:
 --> (https://bugzilla.gnome.org/review?bug=641204&attachment=277252)

Looking good (will try it later today)

Can you also make a separate patch to proxy the new properties/signals on
dvbbasebin ?

::: sys/dvb/gstdvbsrc.c
@@ +206,3 @@
 #define DEFAULT_STATS_REPORTING_INTERVAL 100
 #define DEFAULT_TIMEOUT 1000000 /* 1 second */
+#define DEFAULT_TUNING_TIMEOUT 10 * GST_MSECOND /* 10 seconds */

s/seconds/milliseconds/ in comment

@@ +1659,3 @@
   struct dtv_properties props;
   struct dtv_property dvb_prop[NUM_DTV_PROPS];
+  GstClockTimeDiff timeout_step = 1 * GST_USECOND;

1 microseconds seems a bit hardcore, no ?

@@ +1664,1 @@
+  GST_DEBUG_OBJECT (object, "gst_dvbsrc_tune_fe");

a better message ? "Starting tuning" for ex ?

@@ +1699,3 @@
+  if (!gst_poll_add_fd (poll_set, &fe_fd)) {
+    GST_WARNING_OBJECT (object, "Could not add frontend fd to poll set");
+    goto fail;

forgot to free the poll_set

@@ +1716,3 @@
+  if (!gst_dvbsrc_set_fe_params (object, &props)) {
+    GST_WARNING_OBJECT (object, "Could not set frontend params");
+    goto fail;

forgot to free the poll_set

@@ +1721,3 @@
+  GST_DEBUG_OBJECT (object, "Setting %d properties", props.num);
+  if (ioctl (object->fd_frontend, FE_SET_PROPERTY, &props) < 0) {
+    GST_WARNING_OBJECT (object, "Error tuning channel: %s", g_strerror
(errno));

so this is not a fatal issue ?

@@ +1745,3 @@
+    GST_WARNING_OBJECT (object,
+        "Unable to lock on signal at desired frequency");
+    goto fail_with_signal;

forgot to free the poll set

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.