[Bug 725221] dashdemux: Implement RFC 3986 compliant URL joiner

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=725221
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #274241|none                        |reviewed
             status|                            |

--- Comment #13 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-05-28 12:35:48 UTC ---
Review of attachment 274241:
 --> (https://bugzilla.gnome.org/review?bug=725221&attachment=274241)

::: gst/gsturi.h
@@ +213,3 @@
+ */
+
+GstUri * gst_uri_new                       (const gchar * uri) G_GNUC_MALLOC;

I would prefer a component-based constructor here that automatically escapes
the components... and then a gst_uri_from_string()

@@ +222,3 @@
+gboolean gst_uri_is_writable               (GstUri * uri);
+GstUri * gst_uri_make_writable             (GstUri * uri);
+gchar *  gst_uri_as_string                 (const GstUri * uri) G_GNUC_MALLOC;

gst_uri_to_string()

@@ +231,3 @@
+gchar *  gst_uri_escape_query              (const gchar * query);
+gchar *  gst_uri_escape_http_query_element (const gchar * element);
+gchar *  gst_uri_escape_fragment           (const gchar * fragment);

These escape functions should maybe be private

But additionally I think per-component setters would be useful (that
automatically escape), and a gst_uri_get_parent() that walks the path
components and a gst_uri_append_path() and things like that to make the path
handling a bit simpler

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.