[Bug 730870] androidmedia: hw decoder doesn't work properly on mtk 8125

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=730870
  GStreamer | gst-plugins-bad | git

Nicolas Dufresne <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #277366|none                        |needs-work
             status|                            |

--- Comment #6 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-05-28 14:04:29 UTC ---
Review of attachment 277366:
 --> (https://bugzilla.gnome.org/review?bug=730870&attachment=277366)

Also, a quick research shows that this code has "Rafaël Carré
<funman at videolanorg>" has author, and you use an anonymous name (are you Rafaël
?). When copy pasting code, first you should test and compile it, validate the
licence (in this case it's LGPL, so it ok) then you should give original author
credits, and for patches submitted to GStreamer, you should use your real full
name in the From field.

::: sys/androidmedia/gstamc.c
@@ +2750,3 @@
+            vptr = v_luma + luma_idx;
+            cptr = c_luma;
+            memcpy (*dest, *src, tile_width);

Something is wrong here I think. vptr and cptr are updated but unused. And
dest/src is undefined.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.