[Bug 730901] example: ts-parser: add linkage descriptor

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Wed May 28 22:56:23 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=730901
  GStreamer | gst-plugins-bad | git

Edward Hervey <bilboed> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #277408|none                        |needs-work
             status|                            |

--- Comment #2 from Edward Hervey <bilboed at bilboed.com> 2014-05-29 05:56:18 UTC ---
Review of attachment 277408:
 --> (https://bugzilla.gnome.org/review?bug=730901&attachment=277408)

::: tests/examples/mpegts/ts-parser.c
@@ +79,3 @@

+static void
+dump_memory_bytes (guint8 * data, guint len, guint spacing)

Can you also refactor dump_memory_content() to call this (with desc->data + 2,
desc->length - 2) ?

@@ +451,3 @@
+    }
+    if (res.private_data_length > 0) {
+      dump_memory_bytes (res.private_data_bytes, res.private_data_length,

Just realized that these fields (and other fields of the linkagedescriptor) are
being leaked because they don't have a free/reset function.

I'm going to open a separate bug regarding this (common) issue

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list