[Bug 730968] New: gst_pad_get_range nullability

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu May 29 17:30:04 PDT 2014


https://bugzilla.gnome.org/show_bug.cgi?id=730968
  GStreamer | documentation | unspecified

           Summary: gst_pad_get_range nullability
    Classification: Platform
           Product: GStreamer
           Version: unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: documentation
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: evan at coeus-group.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


The documentation for gst_pad_get_range makes it sound like NULL is a perfectly
reasonable value for the buffer argument, but the code uses
g_return_val_if_fail.  The g_return_val_if_fail documentation says

    If expr evaluates to FALSE, the current function should be considered to
    have undefined behaviour (a programmer error). The only correct solution to
    such an error is to change the module that is calling the current function,
    so that it avoids this incorrect call.

Either the documentation should be changed, or the check shouldn't use
g_return_val_if_fail.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list