[Bug 712809] d3dvideosink shows corrupted output with some videos

Sat May 31 05:54:05 PDT 2014

https://bugzilla.gnome.org/show_bug.cgi?id=712809
  GStreamer | gst-plugins-bad | git

--- Comment #9 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2014-05-31 12:54:01 UTC ---
(In reply to comment #7)
> 
> The pitch is in bytes, the padding in the alignment is in pixels. I think your
> calculations mix those two units in incompatible ways. You divide by the pitch
> by the pixel stride, which gives you the number of pixels but will fail if the
> pitch is not a multiple of the pixel stride due to rounding errors. Consider
> the case of 3-byte RGB and a pitch of 4 (for width=1) as a simple case.

I'm not mixing it, just being lazy, as anyway I can't test anything here.

> 
> I don't think you can safely use the alignment API here. But you're right that
> the problem is most likely in that lines of code. Someone should go through
> those calculations and compare them to the MS documentation.

No fully correct, we can check what power of two the alignment the stride uses,
and set the stride alignment in the same structure. This way you don't need
pixel/bytes conversion.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.