[Bug 737810] payloaders: VP8 and Opus payloader should probably suppport Google Chrome encoding-names
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Sat Nov 1 10:17:06 PDT 2014
https://bugzilla.gnome.org/show_bug.cgi?id=737810
GStreamer | gst-plugins-good | git
--- Comment #13 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-11-01 17:16:58 UTC ---
Review of attachment 289782:
--> (https://bugzilla.gnome.org/review?bug=737810&attachment=289782)
::: ext/opus/gstrtpopuspay.c
@@ +49,3 @@
"payload = (int) " GST_RTP_PAYLOAD_DYNAMIC_STRING ", "
"clock-rate = (int) 48000, "
+ "encoding-name = (string) { \"OPUS\", \"X-GST-OPUS-DRAFT-SPITTKA-00\"
}")
Doesn't this require code inside the payloader subclass to properly negotiate
the encoding-name? Or is that magically handled by the baseclass (by just
calling gst_caps_fixate() if after intersection with downstream there are still
multiple options, which then effectively always uses OPUS)?
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
More information about the gstreamer-bugs
mailing list