[Bug 739598] New: rfbsrc:

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=739598
  GStreamer | gst-plugins-bad | 1.4.3

           Summary: rfbsrc:
    Classification: Platform
           Product: GStreamer
           Version: 1.4.3
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: blake.tregre at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=289955)
 View: https://bugzilla.gnome.org/attachment.cgi?id=289955
 Review: https://bugzilla.gnome.org/review?bug=739598&attachment=289955

patch implementing _get_caps and _set_caps

rfbsrc calculates its caps from RfbDecoder after a connection is made to a
server and then sets the caps on the pad.  However, when caps negotiation
happens, caps are calculated from the pad's template caps and the peer's caps. 
This usually means that RGB is selected, but it does not reflect the format of
the data the decoder is producing.  That is to say, RGB will probably be
negotiated, but the pushed buffers could actually contain BGRx video data.  To
fix this, I've squirreled away the appropriate caps in the RfbDecoder and use
those in overriding _get_caps and _set_caps.  I'm unfamiliar with caps
negotiation, so please point me in the right direction if this isn't correct.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.