[Bug 699364] dshowvideosink: port to 1.0

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=699364
  GStreamer | gst-plugins-bad | 1.x

Julien Isorce <julien.isorce> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #242979|none                        |reviewed
             status|                            |

--- Comment #5 from Julien Isorce <julien.isorce at gmail.com> 2014-11-04 08:22:25 UTC ---
Review of attachment 242979:
 --> (https://bugzilla.gnome.org/review?bug=699364&attachment=242979)

I added some remarks but it looks good. 

As a follow-up, I mean in an other bug you could use:
GstVideoFrame src;
ret = gst_video_frame_map (&src, &info, buf, GST_MAP_READ); 
It will simply "CopyToDestinationBuffer".

Also could investigate if it is possible to build a GstBufferPool of
IMediaSample.
The blocking thing I see if whether or not it is possible to retrieve the dshow
samples when setting up the graph (asking for N sample).
And then wrap them GstMemory. Also it raises the question if dshow can handle
non-contiguous planes like V4l2.

::: sys/dshowvideosink/dshowvideofakesrc.cpp
@@ +258,3 @@
   AM_MEDIA_TYPE *mediatype;

+  gst_buffer_map (buffer, &map, GST_MAP_READ);

You should check return value of gst_buffer_map

::: sys/dshowvideosink/dshowvideosink.cpp
@@ +70,1 @@


Does it really implement navigation ?

@@ +1698,3 @@
   else if (IsEqualGUID (mediatype->subtype, MEDIASUBTYPE_UYVY))
+    caps = gst_caps_new_simple ("video/x-raw",
+            "format", GST_TYPE_VIDEO_FORMAT, GST_VIDEO_FORMAT_UYVY, NULL);

Where YUYV has gone ? Maybe you need to check whether it's available or not.

@@ +1797,3 @@
+          fourcc = GST_MAKE_FOURCC ('Y', 'U', 'Y', '2');
+          bpp = 16;
+          break;

Same question here.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.