[Bug 739620] New: input-selector: _activate_sinkpad conflates two different functions

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=739620
  GStreamer | gstreamer (core) | 1.4.3

           Summary: input-selector: _activate_sinkpad conflates two
                    different functions
    Classification: Platform
           Product: GStreamer
           Version: 1.4.3
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: jan.steffens at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Seems input-selector contains a lot of bit-rot.

gst_input_selector_activate_sinkpad is used to:

1) get the current active sink pad, falling back to the first existing pad,
2) Set the "active" field on the given pad to TRUE.

The function 2) seems to be a remnant from when _activate_sinkpad still used
the given pad as the fallback pad. This function should be split into two
separate functions.

Also, it seems the "active" field of the sink pad is just used to determine
whether the running-time property returns 0.

However, since this field is set on any activity it cannot be used to determine
whether gst_segment_to_running_time works or not. This should probably be
changed to check if the segment is defined and return GST_CLOCK_TIME_NONE if it
is not.

In addition, Bug 736891 is something to clean up. The block signal can only be
undone by state-change.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.