[Bug 738285] playbin: Sequential playback of the file list does not work

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=738285
  GStreamer | gst-plugins-base | git

--- Comment #68 from Andrei Sarakeev <sarakusha at gmail.com> 2014-11-05 08:15:23 UTC ---
Review of attachment 289637:
 --> (https://bugzilla.gnome.org/review?bug=738285&attachment=289637)

::: gst/playback/gstdecodebin2.c
@@ +471,3 @@
 static gboolean gst_decode_chain_is_drained (GstDecodeChain * chain);
+static gboolean gst_decode_group_is_drained (GstDecodeGroup * group);
+#endif

These static functions call each other, and nowhere more (circular reference).

@@ +4641,3 @@
+  GstDecodePad *dpad = GST_DECODE_PAD (parent);
+  GstFlowReturn ret = gst_proxy_pad_chain_default (pad, parent, buffer);
+  gboolean notlinked = (ret == GST_FLOW_NOT_LINKED);

You know better, but that's exactly what I need. No matter: success or failed,
only not-linked (comment 39)

::: tests/check/elements/playbin-complex.c
@@ +1036,3 @@
+  gst_object_unref (bus);
+
+      ("caps:video/x-raw, "

if the about-to-finish signal is emitted several times (from different
threads), then the next check "fail_unless (remaining == 0)"  could be
completed successfully, but could fail (fifty-fifty). Adding a delay we will be
sure that all calls completed.

@@ +1037,3 @@
+
+  g_usleep (10000);
+      "format=(string)I420, "

What should I do? We can try to count the number of STREAM_START messages.

@@ +1138,3 @@
+      g_signal_connect (G_OBJECT (playbin), "about-to-finish",
+      (GCallback) play_next, &remaining);
+  gboolean done = FALSE;

Ok

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.