[Bug 739640] tests : fix leaks in adder unit test.
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Wed Nov 5 04:46:21 PST 2014
https://bugzilla.gnome.org/show_bug.cgi?id=739640
GStreamer | gst-plugins-base | git
Tim-Philipp Müller <t.i.m> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #289989|none |reviewed
status| |
--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2014-11-05 12:46:15 UTC ---
(From update of attachment 289989)
Thanks for the patch. Mostly looks good to me, just a few minor comments: could
you please change your name in the git commit message to a proper name with
capitalization and spaces etc.
In test_place_twice() the event should just be sent without the _ref(), then
there's no need to unref it in the end during clean-up (that pattern is only
needed when it's sent inside a loop).
Also, I'm not sure why you marked this as severity=major, it's pretty much the
least severe kind of issue there is :)
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list