[Bug 739440] GstGLMemory lazy malloc system memory

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=739440
  GStreamer | gst-plugins-bad | git

Matthew Waters <ystreet00> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #289714|none                        |needs-work
             status|                            |

--- Comment #1 from Matthew Waters <ystreet00 at gmail.com> 2014-11-06 05:13:59 UTC ---
Review of attachment 289714:
 --> (https://bugzilla.gnome.org/review?bug=739440&attachment=289714)

Just on thread safety comment :)

Looks good otheriwise.

::: gst-libs/gst/gl/gstglmemory.c
@@ +661,3 @@
+
+    if (!gl_mem->data) {
+      gl_mem->data = g_malloc (gl_mem->mem.maxsize);

Nothing stops the map function being called concurrently so this needs to be
protected by either a GOnce or a mutex to avoid accidentally double allocating.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.