[Bug 739544] test and fix tcp (socket) elements

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=739544
  GStreamer | gst-plugins-base | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #289856|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-11-06 11:02:30 UTC ---
Review of attachment 289856:
 --> (https://bugzilla.gnome.org/review?bug=739544&attachment=289856)

Looks mostly good, thanks!

::: tests/check/pipelines/socketintegrationtest.c
@@ +79,3 @@
+      GST_CLOCK_TIME_NONE);
+  gst_element_get_state (GST_ELEMENT (st->src_pipeline), NULL, NULL,
+      GST_CLOCK_TIME_NONE);

Downwards state changes should be immediate, don't wait for them to finish

@@ +82,3 @@
+
+  g_object_unref (st->sink_pipeline);
+  g_object_unref (st->src_pipeline);

gst_object_unref()

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.