[Bug 739685] RFC: add API to GstPreset to compare presets

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=739685
  GStreamer | gstreamer (core) | 1.x

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #290051|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-11-06 11:05:30 UTC ---
Review of attachment 290051:
 --> (https://bugzilla.gnome.org/review?bug=739685&attachment=290051)

::: gst/gstpreset.c
@@ +1237,3 @@
+ */
+gfloat
+gst_preset_distance (GstPreset * preset, const gchar * name)

A float value and "distance" seems weird. Maybe call it "compare" and if you
need more than just "equal" and "not equal", use enums? "equal", "almost
equal", ... or so

But it seems difficult to quantize the similarity of presets in a meaningful
way.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.