[Bug 739446] silence allocation patch - current Implementation is wrong

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=739446
  GStreamer | gst-plugins-base | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #290101|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-11-06 13:35:38 UTC ---
Review of attachment 290101:
 --> (https://bugzilla.gnome.org/review?bug=739446&attachment=290101)

Please attach the patch(es) in "git format-patch" format :)

::: ext/alsa/gstalsa.c
@@ +150,3 @@
   finfo = gst_audio_format_get_info (format);

+  if ((GST_AUDIO_FORMAT_INFO_ENDIANNESS (finfo) != endianness) &&
(GST_AUDIO_FORMAT_INFO_ENDIANNESS (finfo) != 0))

Why? Also please split the alsa specific part into a separate patch :)

::: gst-libs/gst/audio/gstaudiosink.c
@@ +416,2 @@
   buf->size = spec->segtotal * spec->segsize;
+#if 0

This part makes sense, but please just remove the old code instead of
commenting it out

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.