[Bug 739440] GstGLMemory lazy malloc system memory

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Thu Nov 6 19:17:05 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=739440
  GStreamer | gst-plugins-bad | git

comicfans44 <comicfans44> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #289714|0                           |1
        is obsolete|                            |

--- Comment #2 from comicfans44 <comicfans44 at gmail.com> 2014-11-07 03:17:02 UTC ---
Created an attachment (id=290131)
 View: https://bugzilla.gnome.org/attachment.cgi?id=290131
 Review: https://bugzilla.gnome.org/review?bug=739440&attachment=290131

misc patch to lazy malloc glmemory's system memory

(In reply to comment #1)
> Review of attachment 289714 [details]:
> 
> Just on thread safety comment :)
> 
> Nothing stops the map function being called concurrently so this needs to be
> protected by either a GOnce or a mutex to avoid accidentally double allocating.


use g_once to avoid double allocating, also lazy allocate memory 
in copy codepath (NEEDS_DOWNLOAD=true but not mapped for system R/W yet).
not familiar with g_once, please point out my problem if any :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list