[Bug 739544] test and fix tcp (socket) elements

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Nov 7 01:16:48 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=739544
  GStreamer | gst-plugins-base | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|HEAD                        |1.5.1

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-11-07 09:16:44 UTC ---
Thanks for the patches. I renamed the test to "tcp" for consistency as all
other pipeline tests specific to a plugin are also directly named after the
plugin. Will be harder to check if a test already exists for a plugin otherwise
:)

commit ffb43c059197ece6f203949dfdedfc2a9f18af92
Author: William Manley <will at williammanley.net>
Date:   Thu Nov 6 14:14:22 2014 +0000

    tcpserversink: Don't leak a `GSocket` and a `GInetSocketAddress`

    when accepting a connection.

    Discovered by `make check-valgrind` with the new `socketintegrationtest`.

    https://bugzilla.gnome.org/show_bug.cgi?id=739544

commit 5b0ec93e99a091c9708df83a0f645593d3b31da8
Author: William Manley <will at williammanley.net>
Date:   Mon Nov 3 01:08:27 2014 +0000

    tests: Add TCP pipelines test

    There don't seem to be any unit tests for the socket handling elements.  As
    I am about to attempt some refactorings I've added some basic tests which
    exercise some of the happy-paths in tcpclientsrc, tcpserversrc,
    tcpserversink and tcpclientsink.  They should let me know if I've caused
    serious breakage.

    They are far from exhaustive but are sufficient for me to have caught a few
    memory-leaks in the existing code.

    https://bugzilla.gnome.org/show_bug.cgi?id=739544

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list