[Bug 738526] vc1parse: implement some stream-format conversion

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=738526
  GStreamer | gst-plugins-bad | git

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #288960|none                        |needs-work
             status|                            |

--- Comment #15 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-11-07 09:34:16 UTC ---
Review of attachment 288960:
 --> (https://bugzilla.gnome.org/review?bug=738526&attachment=288960)

::: gst/videoparsers/gstvc1parse.c
@@ +1426,3 @@
+
+  startcode = GST_READ_UINT32_BE (minfo.data);
+  gst_buffer_unmap (buffer, &minfo);

You don't check here if you actually have 4 bytes to read the start code. Also
you could use gst_buffer_extract(), then you don't need to map and unmap
yourself.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.