[Bug 736318] qtdemux: reset qtdemux parsing state on buffer discontinuity

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Fri Nov 7 07:22:23 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=736318
  GStreamer | gst-plugins-good | 1.4.1

Matthieu Bouron <matthieu.bouron> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #286666|none                        |needs-work
             status|                            |

--- Comment #14 from Matthieu Bouron <matthieu.bouron at collabora.com> 2014-11-07 15:22:17 UTC ---
Review of attachment 286666:
 --> (https://bugzilla.gnome.org/review?bug=736318&attachment=286666)

::: gst/isomp4/qtdemux.c
@@ +1991,3 @@
+
+      } else if (segment.format == GST_FORMAT_TIME) {
+        } else {

This call reset qtdemux->upstream_segment to FALSE as well as
qtdemux->pending_newsegment to NULL.

This prevents the new upstream segment to be pushed downstream later on.

A quick ugly fix would to add the following code after the reset call:

gst_event_replace (&demux->pending_newsegment, event);
demux->upstream_newsegment = TRUE;

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list