[Bug 739333] Add AMR decoder

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=739333
  GStreamer | gst-omx | 1.2.4

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #13 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-11-10 08:42:48 UTC ---
(In reply to comment #12)
> slomo, thank you for the correction.
> 
> --
> AMR only supports mono, so add assertions (g_return_val_if_fail
> (pcm_param.nChannels == 1, GST_AUDIO_CHANNEL_POSITION_MONO))  for all the other
> cases here and always return MONO
> --
> Would you mean 
> g_return_val_if_fail (pcm_param.nChannels == 1, FALSE)?
> 
> as the function gst_omx_amr_dec_get_channel_positions requires gboolean type
> return?

Yes

> BTW, if AMR only supports mono, why don't we specify its channels of its cap to
> only channels=(int)1?

That too, I missed that. Sorry :) Nonetheless catching this kind of error
inside the code as mentioned above is also useful.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.