[Bug 739281] video-blend: correct improper logic calculations

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Nov 10 03:14:36 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=739281
  GStreamer | gst-plugins-base | unspecified

Vineeth <vineeth.tm> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #289884|0                           |1
        is obsolete|                            |

--- Comment #43 from Vineeth <vineeth.tm at samsung.com> 2014-11-10 11:14:32 UTC ---
Created an attachment (id=290329)
 View: https://bugzilla.gnome.org/attachment.cgi?id=290329
 Review: https://bugzilla.gnome.org/review?bug=739281&attachment=290329

video-blend update logic calculations

Made changes as per review and added a new src_yoff variable which makes sure
the clipping of the text is proper with respect to y pos.

Right now even though src_xoff is being provided, it is not being used in
unpack function. This will workout with Lazars' patch for adding x variable in
unpack.

I tested corner cases of y position and am able to see that the clipping works
as expected. But x position still cant be tested, without the actual
implementation in unpack.

Please review the patch and give your inputs on the same.


Is it required to write test cases to check exact clipped overlay?
If so, i can think about how to do the same, but in a separate thread/bug :)...

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list