[Bug 739930] Port server-alsasrc-PCMA.py to version 1.x

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Nov 11 09:48:50 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=739930
  GStreamer | gst-plugins-good | git

Olivier Crete (Tester) <olivier.crete> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #290397|none                        |accepted-commit_now
             status|                            |

--- Comment #5 from Olivier Crete (Tester) <olivier.crete at ocrete.ca> 2014-11-11 17:48:47 UTC ---
Review of attachment 290397:
 --> (https://bugzilla.gnome.org/review?bug=739930&attachment=290397)

Looks good

::: tests/examples/rtp/server-alsasrc-PCMA.py
@@ +69,3 @@
+sinkpad = Gst.Element.get_request_pad(rtpbin, 'send_rtp_sink_0')
+srcpad = Gst.Element.get_static_pad(audiopay, 'src')
+lres = Gst.Pad.link(srcpad, sinkpad)

I wonder why we didn't do srcpad.link(sinkpad) here

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list