[Bug 740001] New: [PATCH] GstTask race condition when pausing and stopping

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=740001
  GStreamer | gstreamer (core) | git

           Summary: [PATCH] GstTask race condition when pausing and
                    stopping
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: All
            Status: UNCONFIRMED
          Severity: major
          Priority: Normal
         Component: gstreamer (core)
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: haakon.sporsheim at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


Created an attachment (id=290499)
 View: https://bugzilla.gnome.org/attachment.cgi?id=290499
 Review: https://bugzilla.gnome.org/review?bug=740001&attachment=290499

Test/Example and fix

The GstTask thread entry point looks like this:

static void
gst_task_func (GstTask * task)
{
...
  while (G_LIKELY (GET_TASK_STATE (task) != GST_TASK_STOPPED)) {
    if (G_UNLIKELY (GET_TASK_STATE (task) == GST_TASK_PAUSED)) {
      GST_OBJECT_LOCK (task);
      while (G_UNLIKELY (GST_TASK_STATE (task) == GST_TASK_PAUSED)) {
        g_rec_mutex_unlock (lock);

        GST_TASK_SIGNAL (task);
        GST_INFO_OBJECT (task, "Task going to paused");
        GST_TASK_WAIT (task);
        GST_INFO_OBJECT (task, "Task resume from paused");
        GST_OBJECT_UNLOCK (task);
        /* locking order.. */
        g_rec_mutex_lock (lock);

        GST_OBJECT_LOCK (task);
        if (G_UNLIKELY (GET_TASK_STATE (task) == GST_TASK_STOPPED)) {
          GST_OBJECT_UNLOCK (task);
          goto done;
        }
      }
      GST_OBJECT_UNLOCK (task);
    }

    task->func (task->user_data);
  }
done:
  g_rec_mutex_unlock (lock);

  GST_OBJECT_LOCK (task);
  task->thread = NULL;
...
}

>From what I can see, the while (!stopped) and if (paused) is not guarded by the
object lock. A task func that look like this:
my_task_func ()
{
  ...
  gst_pad_pause_task ();
}

will once in a while cause the taks func to reenter, because another thread may
change the task state to stopped between while (!stopped) and if (paused).


I've attached a patch which adds a test that must be run like this for a couple
of minutes (or hours, depending on SMP/threading):
GST_CHECKS=test_pause_stop_race make -C tests/check gst/gsttask.forever

Theres also a fix in the patch. Without the fix the deadlock will normally
appear after a couple of million runs, in a 1-2minutes on my system. With the
fix I've been running the test for a couple of hours without deadlocking.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.