[Bug 738242] textoverlay: segfault when trying to position text outside of the video frame

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=738242
  GStreamer | gst-plugins-base | unspecified

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk
            Summary|Segfault when trying to     |textoverlay: segfault when
                   |position a textoverlay      |trying to position text
                   |outside of the video frame  |outside of the video frame

--- Comment #11 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2014-11-17 09:57:33 UTC ---
commit 46e727ebdeaf1379b32cbf99e22bfa7788c37bd8
Author: Tim-Philipp Müller <tim at centricular.com>
Date:   Wed Nov 5 21:52:44 2014 +0000

    Revert "basetextoverlay: Fix segfault when overlay outside the frame"

    This is not correct. overlay->silent is a property and we
    should not just flip the property forever because one text
    we render is outside of the frame. The next one might not
    be, the positioning properties can be changed after all.

    The lower layers should handle clipping, and now do.

    This reverts commit 1cc311156cc3908d1d9888fbcda67305fc647337.

    https://bugzilla.gnome.org/show_bug.cgi?id=738984
    https://bugzilla.gnome.org/show_bug.cgi?id=739281

commit a003423bc35f04f061479a8dba26a958b40c82ac
Author: Tim-Philipp Müller <tim at centricular.com>
Date:   Wed Nov 5 21:46:47 2014 +0000

    Revert "basetextoverlay: segfault when xpos >= video size"

    This is not right, even if it might avoid a crash. We don't
    want to just set xpos/ypos to 0 in those cases. Clipping
    should be done properly, see bug #739281 for that.

    This reverts commit 900d0267d511e9553eec44d948d7e33ead7dc903.

    https://bugzilla.gnome.org/show_bug.cgi?id=738984
    https://bugzilla.gnome.org/show_bug.cgi?id=739281

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.