[Bug 740058] pngparse: improve parsing of the image

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Nov 18 10:17:00 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=740058
  GStreamer | gst-plugins-bad | unspecified

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #290620|none                        |rejected
             status|                            |

--- Comment #3 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2014-11-18 18:16:58 UTC ---
(From update of attachment 290620)
Does not look good to me. Without even looking at the other changes, this you
can't do:

>-  guint width = 0, height = 0;
>+  static guint width = 0, height = 0;

or you get problems when running multiple pngparse elements, and you also can't
reset these properly, etc.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list