[Bug 739305] souphttpsrc: log connection events at info level

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=739305
  GStreamer | gst-plugins-good | 1.4.3

Reynaldo H. Verdejo Pinochet <reynaldo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #291099|none                        |needs-work
             status|                            |

--- Comment #3 from Reynaldo H. Verdejo Pinochet <reynaldo at opendot.cl> 2014-11-20 14:59:08 UTC ---
(From update of attachment 291099)
>From bc1a515335d13a50ab98737ded8a9002aa53b87c Mon Sep 17 00:00:00 2001
>From: Branislav Katreniak <bkatreniak at nuvotechnologies.com>
>Date: Tue, 25 Feb 2014 13:28:06 +0100
>Subject: [PATCH 1/2] souphttpsrc: log connection events at info level
>
>These events are non repeating. They get lost at debug level.
>

While I agree these belong to the INFO category rather
than the DEBUG one, I don't understand your "non repeating"
nor your "get lost". Can you elaborate and/or rephrase
your commit message?

> [..]
>diff --git a/ext/soup/gstsouphttpsrc.c b/ext/soup/gstsouphttpsrc.c
>index ad87223..db3b594 100644
>--- a/ext/soup/gstsouphttpsrc.c
>+++ b/ext/soup/gstsouphttpsrc.c
>@@ -1265,7 +1265,8 @@ gst_soup_http_src_finished_cb (SoupMessage * msg, GstSoupHTTPSrc * src)
>     GST_DEBUG_OBJECT (src, "finished, but not for current message");
>     return;
>   }
>-  GST_DEBUG_OBJECT (src, "finished");
>+  GST_INFO_OBJECT (src, "finished, session_io_status:%d",
>+      src->session_io_status);

Add a space after ":" as it's done in the rest of the code.

Looks good otherwise. Thanks.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.