[Bug 699382] v4l2: dmabuf handling is not complete

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=699382
  GStreamer | gst-plugins-good | git

Nicolas Dufresne (stormer) <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #291100|none                        |reviewed
             status|                            |

--- Comment #14 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> 2014-11-20 15:04:14 UTC ---
Review of attachment 291100:
 --> (https://bugzilla.gnome.org/review?bug=699382&attachment=291100)

::: sys/v4l2/gstv4l2object.c
@@ +2290,3 @@
+    if (v4l2object->req_mode == GST_V4L2_IO_AUTO) {
+      GstV4l2BufferPool *vpool = GST_V4L2_BUFFER_POOL_CAST(v4l2object->pool);
+      if (GST_OBJECT_FLAG_IS_SET(vpool->vallocator,
GST_V4L2_ALLOCATOR_FLAG_DMABUF_REQBUFS))

I would prefer if you use the marco:
GST_V4L2_ALLOCATOR_CAN_REQUEST (vpool->allocator, DMABUF)

@@ -2296,6 +2307,0 @@
-  /* Map the buffers */
-  GST_LOG_OBJECT (v4l2object->element, "initiating buffer pool");
-
... 3 more ...

I'm not sure I understand this part, why would setup_pool() not setup the pool
anymore ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.