[Bug 740458] hlsdemux typefind issue

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=740458
  GStreamer | gst-plugins-bad | 1.4.0

--- Comment #2 from Thiago Sousa Santos <thiagossantos at gmail.com> 2014-11-21 06:59:31 UTC ---
Review of attachment 291135:
 --> (https://bugzilla.gnome.org/review?bug=740458&attachment=291135)

I'm torn between this solution and moving this to be handled when typefinding
really fails. This looks simple and should work but having it handled when the
typefind really fails looks more correct.

When typefind fails, one would check if the buffer was large enough for
typefinding and if not, prepend it to the pending_buffer for when more data is
available.

Anyway let's wait for a second opinion to see what others think.

::: ext/hls/gsthlsdemux.c
@@ +876,3 @@

+    /* mpegts typefind fails if size < 4 (208 byte) packets. Round to 1k. */
+    if (demux->do_typefind && available < 1024) {

Please add a G_UNLIKELY here to hint the compiler that this is unlikely to
happen.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.