[Bug 699382] v4l2: dmabuf handling is not complete

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=699382
  GStreamer | gst-plugins-good | git

Nicolas Dufresne (stormer) <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #291165|none                        |needs-work
             status|                            |

--- Comment #21 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> 2014-11-21 14:42:05 UTC ---
Review of attachment 291165:
 --> (https://bugzilla.gnome.org/review?bug=699382&attachment=291165)

::: sys/v4l2/gstv4l2object.c
@@ +3378,3 @@
+    if (allocator)
+      gst_object_unref (allocator);
+    allocator = gst_object_ref (GST_V4L2_BUFFER_POOL (obj->pool)->allocator);

This part should be removed. You can't really do that, since in this particular
case, the buffer pool ignores the config and use a DMA buf allocator, and as
set_config() has not been called, it not yet the allocator that will be used.

I suppose you would like to see the DMABUF allocator in the pool config for
when you receive the buffer downstream (I think you should peek the memories,
but both way works). If that is the case, you should simply add code in
set_config() of the pool to also update the allocator. I just didn't thought
about it, so there is no code yet.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.