[Bug 737591] rtpgstdepay: buffer overread

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=737591
  GStreamer | gst-plugins-good | git

--- Comment #9 from Wim Taymans <wim.taymans at gmail.com> 2014-11-21 15:53:48 UTC ---
(In reply to comment #8)
> Is this complete with this commit? Also should we backport the rtgst* changes
> to 1.4 too? Seems relatively safe, I'm just a little bit worried that we missed
> a backwards incompatible change in here.

I think it's safe to backport. I can't see a scenario that would cause failure.

the compatibility matrix is like:

* old pay -> old depay: 

     no change, with upgraded core it would not crash on certain malformed
input.

* old pay -> new depay: 

    new depay finds ; at end and parses the message. core change doesn't
matter.

* new pay -> old depay:

    new depay puts extra 0 after string. old depay just parses and skips the
extra 0 byte (because it is included in the length). With new core, certain
malformed payloads are not crashing.

* new pay -> new depay:

   new pay adds extra 0 after string, new depay checks for 0 and decodes. new
core will avoid certain buffer overreads.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.