[Bug 740222] libav: Video decoder push buffer mapped in READ/WRITE

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=740222
  GStreamer | gst-libav | 1.4.4

--- Comment #10 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> 2014-11-22 16:37:00 UTC ---
Created an attachment (id=291241)
 View: https://bugzilla.gnome.org/attachment.cgi?id=291241
 Review: https://bugzilla.gnome.org/review?bug=740222&attachment=291241

GL Side workaround

So with this kind of patch, I can get this to work without patching gst-libav.
It still seem quite wrong to me to push a buffer in write. It's like saying,
I'm done but not really done, sorry if I break your rendering. I think I'd
prefer if we could downgrade a READWRITE map to READ only. After what the only
way to write in it again would be to unmap/map it.

Note that this patch assume that mapping in write only will require a full
write. This may or may not be correct. Someone could get fooled with this,
thinking MAP_WRITE is find to overlay an opaque rectangle, which in fact may
result if an opaque rectangle with random data surrounding it (or instead of
random, some data from previous run).

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.