[Bug 740502] Add absolute property to GstDirectControlBinding

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=740502
  GStreamer | gstreamer (core) | git

Stefan Sauer (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #291183|none                        |needs-work
             status|                            |

--- Comment #3 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2014-11-24 12:33:45 UTC ---
Review of attachment 291183:
 --> (https://bugzilla.gnome.org/review?bug=740502&attachment=291183)

The documentation blob at the top needs to be updates as well. 
I would not mind to see the example being turned into a patch for
tests/examples/controller/.

::: libs/gst/controller/gstdirectcontrolbinding.c
@@ +191,3 @@
+      g_param_spec_boolean ("absolute", "Absolute",
+      "Whether the control values are absolute",
+      DEFAULT_PROP_ABSOLUTE, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS);

just put FALSE here and remove the DEFAULT_PROP_ABSOLUTE (please not that
G_PARAM_CONSTRUCT can be used to initialize the default).

Also does it make sense to ever switch this at run-time? Can this be
G_PARAM_CONSTRUCT_ONLY? If construct-only you can make two sets of mapping
functions and avoid the if (self->want_absolute) at runtime - this code is
getting called quite often.

@@ +199,3 @@
 gst_direct_control_binding_init (GstDirectControlBinding * self)
 {
+  self->want_absolute = DEFAULT_PROP_ABSOLUTE;

the object is cleared to zero by default.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.