[Bug 740694] decodebin2: Take STREAM_LOCK before sending sticky events.

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Tue Nov 25 08:24:51 PST 2014


https://bugzilla.gnome.org/show_bug.cgi?id=740694
  GStreamer | gst-plugins-base | unspecified

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #291473|none                        |accepted-commit_now
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2014-11-25 16:24:46 UTC ---
Review of attachment 291473:
 --> (https://bugzilla.gnome.org/review?bug=740694&attachment=291473)

Looks good except for a typo

::: gst/playback/gstdecodebin2.c
@@ +2371,3 @@
+    /* First lock element's sinkpad stream lock so no data reaches
+     * the possible new element added when caps are sent by element
+     * while we're still sending stickies */

sticky events you mean, not stickies ;)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list