[Bug 739854] validate:scenario: Properly handle ASYNC action execution in the API
GStreamer (bugzilla.gnome.org)
bugzilla at gnome.org
Tue Nov 25 10:35:05 PST 2014
https://bugzilla.gnome.org/show_bug.cgi?id=739854
GStreamer | gst-devtools | unspecified
Mathieu Duponchelle <mathieu.duponchelle> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #290284|none |reviewed
status| |
--- Comment #4 from Mathieu Duponchelle <mathieu.duponchelle at epitech.eu> 2014-11-25 18:35:01 UTC ---
Review of attachment 290284:
--> (https://bugzilla.gnome.org/review?bug=739854&attachment=290284)
All good except for that :)
::: validate/gst/validate/gst-validate-internal.h
@@ +34,3 @@
typedef struct _GstValidateActionType GstValidateActionType;
+#define IS_CONFIG_ACTION_TYPE(type) (((type) &
GST_VALIDATE_ACTION_TYPE_CONFIG) || ((type) == TRUE))
A comment would be welcome here to explain why || ((type) == TRUE) is needed.
--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list