[Bug 740236] New interleave2 based on GstAggregator and create GstAudioAggregator from audiomixer

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=740236
  GStreamer | gst-plugins-bad | git

Thibault Saunier <tsaunier> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #291390|none                        |reviewed
             status|                            |

--- Comment #30 from Thibault Saunier <tsaunier at gnome.org> 2014-11-25 21:19:12 UTC ---
Review of attachment 291390:
 --> (https://bugzilla.gnome.org/review?bug=740236&attachment=291390)

Looks generally good, have not gone into details though.

::: gst/audiomixer/gstaudioaggregator.h
@@ +66,3 @@
+ * GstAudioAggregatorPad:
+ * @buffer: currently queued buffer.
+ * @segment: last segment received.

Can't see those 2 fields here :)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.